Fix/passthrough header save #868
Merged
+35
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
arjavdongaonkar
force-pushed
the
fix/passthrough-header-save
branch
from
557cddb to
22fcf81
Compare
Signed-off-by: Arjav <[email protected]>
Signed-off-by: Arjav <[email protected]>
crivetimihai
force-pushed
the
fix/passthrough-header-save
branch
from
22fcf81 to
c9fffb8
Compare
- Add missing passthrough_headers field to DbGateway creation in register_gateway() - Add method="POST" to add-tool-form, add-resource-form, and add-gateway-form - Standardize all add form handlers to use fetch() instead of fetchWithTimeout() - Remove redirect: "manual" option that was interfering with form responses
crivetimihai
force-pushed
the
fix/passthrough-header-save
branch
from
7977aaa to
8702a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Before opening this PR please:
make lint- passesruff,mypy,pylintmake test- all unit + integration tests greenmake coverage- ≥ 90 %make docker docker-run-sslormake podman podman-run-ssl📌 Summary
Edit Gateway API does not persist the passthrough_headers field from GatewayUpdate.
Although the field exists in the GatewayUpdate model, it is ignored during update and never stored in the DB.
🔁 Reproduction Steps
Create a Gateway Server.
Reopen the "Edit" modal.
Fill in the Passthrough Headers input and hit save
Observe that Passthrough headers are not saved
issue: #867
🐞 Root Cause
This was confirmed in the update_gateway method: while it updates name, url, tags, auth, etc., it never checks gateway_update.passthrough_headers.
💡 Fix Description
Update passthrough headers as well
🧪 Verification
make lintmake testmake coverage📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)